[
https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456667#comment-16456667
]
Hadoop QA commented on OOZIE-3217:
----------------------------------
Testing JIRA OOZIE-3217
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:red}-1{color} the patch contains 4 line(s) longer than 132
characters
. {color:green}+1{color} the patch adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [3] new bugs found below threshold in total that
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [3] new bugs found below threshold in [core]
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important FindBugs errors are:
. At AuthorizationService.java:[line 193]: Found reliance on default encoding
in
org.apache.oozie.service.AuthorizationService.loadAdminUsersFromAdminUsersFile():
new java.io.InputStreamReader(InputStream)
. At AuthorizationService.java:[line 193]:
org.apache.oozie.service.AuthorizationService.loadAdminUsersFromAdminUsersFile()
may fail to close stream
. At AuthorizationService.java:[line 190]:
java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file
whose location might be specified by user input
. At AuthorizationService.java:[line 188]
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 2114
. Tests failed: 1
. Tests errors: 1
. The patch failed the following testcases:
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
. Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
. {color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestOozieDBCLI#testOozieDBCLI
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/496/
> Enable definition of admin users using oozie-site.xml
> -----------------------------------------------------
>
> Key: OOZIE-3217
> URL: https://issues.apache.org/jira/browse/OOZIE-3217
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: 5.0.0
> Reporter: Peter Orova
> Assignee: Peter Orova
> Priority: Minor
> Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch
>
>
> Currently the list of admin users is defined in the {{adminusers.txt}} file
> hard coded to the Oozie config dir. For a more streamlined solution, we could
> define the list of admin users via {{oozie-site.xml}} by introducing the
> following configuration, which receives the comma separated values of the
> users that are admins.
> {{oozie.service.AuthorizationService.admin.users}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
