[
https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465735#comment-16465735
]
Andras Piros commented on OOZIE-3217:
-------------------------------------
[~orova] failing tests seem unrelated.
Can you please fix following pre-commit build errors:
{quote}
-1 RAW_PATCH_ANALYSIS
. -1 the patch contains 3 line(s) longer than 132 characters
. -1 There are [3] new bugs found below threshold in [core] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important FindBugs errors are:
. At AuthorizationService.java:[line 192]: Found reliance on default encoding
in org.apache.oozie.service.AuthorizationService.loadAdminUsersFromFile(): new
java.io.InputStreamReader(InputStream)
. At AuthorizationService.java:[line 192]:
org.apache.oozie.service.AuthorizationService.loadAdminUsersFromFile() may fail
to close stream
. At AuthorizationService.java:[line 189]:
java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file whose
location might be specified by user input
. At AuthorizationService.java:[line 187]
{quote}
> Enable definition of admin users using oozie-site.xml
> -----------------------------------------------------
>
> Key: OOZIE-3217
> URL: https://issues.apache.org/jira/browse/OOZIE-3217
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: 5.0.0
> Reporter: Peter Orova
> Assignee: Peter Orova
> Priority: Minor
> Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch,
> OOZIE-3217.003.patch
>
>
> Currently the list of admin users is defined in the {{adminusers.txt}} file
> hard coded to the Oozie config dir. For a more streamlined solution, we could
> define the list of admin users via {{oozie-site.xml}} by introducing the
> following configuration, which receives the comma separated values of the
> users that are admins.
> {{oozie.service.AuthorizationService.admin.users}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
