[
https://issues.apache.org/jira/browse/OOZIE-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475627#comment-16475627
]
Peter Cseh commented on OOZIE-3250:
-----------------------------------
Thanks for the fixes [~andras.piros]!
I get itchy when I look at
testInterningSameByteArrayManyTimesDoesNotIncreaseHeap(). It feels like this
will be the next flaky test we're chasing. I don't think it's worth keeping. I
still have a dream when we're capable of running tests in parallel and this
test is probably one working against that. Please remove it.
If weakIntern() works as I think it does it may get slow after it have
internalized a lot of arrays. Can you do a measurement of 10k byte[]s of random
lengths but the same content (as an easily coded worst-case-like scenario)? I
don't think it will count but still, things will get slower if the number of
internalized arrays is big.
> Reduce heap waste by reducing duplicate byte[] count
> ----------------------------------------------------
>
> Key: OOZIE-3250
> URL: https://issues.apache.org/jira/browse/OOZIE-3250
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.0.0
> Reporter: Andras Piros
> Assignee: Andras Piros
> Priority: Major
> Attachments: OOZIE-3250.001.patch, OOZIE-3250.002.patch,
> OOZIE-3250.003.patch
>
>
> Similar to OOZIE-3232, we also need to intern the {{byte[]}} field values
> within
> [*{{BinaryBlob}}*|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/BinaryBlob.java#L32-L33]
> and
> [*{{StringBlob}}*|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/StringBlob.java#L34]
> to reduce heap waste caused by duplicate {{byte[]}} entries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
