[ 
https://issues.apache.org/jira/browse/OOZIE-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476293#comment-16476293
 ] 

Misha Dmitriev commented on OOZIE-3250:
---------------------------------------

The last patch looks good to me. Thank you for your efforts, [~andras.piros]

It's great that you tested performance of this stuff. I realize that the 
performance measurement code is fragile so it doesn't make sense to keep it as 
a test that gets re-run regularly. But I think it would make sense to at least 
mention your performance numbers in the javadoc of the ByteArrayUtils class, so 
that in the future people don't have doubts about it.

> Reduce heap waste by reducing duplicate byte[] count
> ----------------------------------------------------
>
>                 Key: OOZIE-3250
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3250
>             Project: Oozie
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.0.0
>            Reporter: Andras Piros
>            Assignee: Andras Piros
>            Priority: Major
>         Attachments: OOZIE-3250.001.patch, OOZIE-3250.002.patch, 
> OOZIE-3250.003.patch, OOZIE-3250.004.patch, OOZIE-3250.005.patch
>
>
> Similar to OOZIE-3232, we also need to intern the {{byte[]}} field values 
> within 
> [*{{BinaryBlob}}*|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/BinaryBlob.java#L32-L33]
>  and 
> [*{{StringBlob}}*|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/StringBlob.java#L34]
>  to reduce heap waste caused by duplicate {{byte[]}} entries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to