> On July 2, 2018, 2:01 p.m., Peter Bacsko wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 256-259 (patched) > > <https://reviews.apache.org/r/66930/diff/6/?file=2041662#file2041662line257> > > > > To me this looks weird. The class is named "configuration", which is > > telling me that it holds data. But it doesn't just hold data, it also > > performs an FS operation.
You are right, I have moved it to ConcurrentCopyFromLocal - Kinga ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/#review205638 ----------------------------------------------------------- On June 18, 2018, 10:03 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66930/ > ----------------------------------------------------------- > > (Updated June 18, 2018, 10:03 a.m.) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > On a busy Hadoop cluster it can happen that users cannot install properly > Oozie ShareLib. > > > Diffs > ----- > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java dce1c559 > tools/src/test/java/org/apache/oozie/tools/OozieSharelibFileOperations.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestBlockSizeCalculator.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestConcurrentCopyFromLocal.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestCopyTaskCallable.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java > ccad273b > > > Diff: https://reviews.apache.org/r/66930/diff/6/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >
