----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/#review205672 -----------------------------------------------------------
tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java Line 226 (original), 245 (patched) <https://reviews.apache.org/r/66930/#comment288564> Remove comment tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java Lines 251 (patched) <https://reviews.apache.org/r/66930/#comment288565> Remove comment tools/src/test/java/org/apache/oozie/tools/TestCopyTaskCallable.java Lines 129 (patched) <https://reviews.apache.org/r/66930/#comment288566> Almost - I think the try block should include more code, just to be safe. At least from the for loop where you call listFiles(). At that point, the pool already exists. - Peter Bacsko On júl. 3, 2018, 8:12 de, Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66930/ > ----------------------------------------------------------- > > (Updated júl. 3, 2018, 8:12 de) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > On a busy Hadoop cluster it can happen that users cannot install properly > Oozie ShareLib. > > > Diffs > ----- > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java dce1c559 > tools/src/test/java/org/apache/oozie/tools/OozieSharelibFileOperations.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestBlockSizeCalculator.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestConcurrentCopyFromLocal.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestCopyTaskCallable.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java > f53d987c > > > Diff: https://reviews.apache.org/r/66930/diff/7/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >
