----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68180/#review206836 -----------------------------------------------------------
examples/pom.xml Lines 108-112 (patched) <https://reviews.apache.org/r/68180/#comment289925> Can you please look whether `com.github.stefanbirkner:system-rules` [CPL 1.0](https://github.com/stefanbirkner/system-rules/blob/master/LICENSE) is compatible with Apache 2.0? examples/src/test/java/org/apache/oozie/example/TestDateList.java Lines 1 (patched) <https://reviews.apache.org/r/68180/#comment289927> Apache 2.0 license header missing. examples/src/test/java/org/apache/oozie/example/TestDateList.java Lines 27 (patched) <https://reviews.apache.org/r/68180/#comment289926> Neat :) - András Piros On Aug. 3, 2018, 6:38 a.m., Daniel Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68180/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2018, 6:38 a.m.) > > > Review request for oozie and András Piros. > > > Repository: oozie-git > > > Description > ------- > > The oozie/examples/src/main/java/org/apache/oozie/example/DateList.java > produces a wrong action output: > > ,2009-02-01T01:15Z,2009-02-01T01:30Z,2009-02-01T01:45Z,2009-02-01T02:00Z > instead of > > 2009-02-01T01:00Z,2009-02-01T01:15Z,2009-02-01T01:30Z,2009-02-01T01:45Z > the first element is missing in the list (but not the separator). This is > caused by an off-by-one error introduced in OOZIE-2942. > > > Diffs > ----- > > examples/pom.xml 680e3fb1 > examples/src/main/java/org/apache/oozie/example/DateList.java 731fe413 > examples/src/test/java/org/apache/oozie/example/TestDateList.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68180/diff/1/ > > > Testing > ------- > > > Thanks, > > Daniel Becker > >
