----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68180/#review206878 -----------------------------------------------------------
examples/src/main/java/org/apache/oozie/example/DateList.java Lines 43-47 (patched) <https://reviews.apache.org/r/68180/#comment289982> Could be extracted to `createDateList()`. examples/src/test/java/org/apache/oozie/example/TestDateList.java Lines 63-64 (patched) <https://reviews.apache.org/r/68180/#comment289979> Please use telling assertion error messages. examples/src/test/java/org/apache/oozie/example/TestDateList.java Lines 76 (patched) <https://reviews.apache.org/r/68180/#comment289980> Please remove. examples/src/test/java/org/apache/oozie/example/TestDateList.java Lines 87 (patched) <https://reviews.apache.org/r/68180/#comment289981> Please use telling assertion error messages. - András Piros On Aug. 6, 2018, 8:57 a.m., Daniel Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68180/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 8:57 a.m.) > > > Review request for oozie and András Piros. > > > Repository: oozie-git > > > Description > ------- > > The oozie/examples/src/main/java/org/apache/oozie/example/DateList.java > produces a wrong action output: > > ,2009-02-01T01:15Z,2009-02-01T01:30Z,2009-02-01T01:45Z,2009-02-01T02:00Z > instead of > > 2009-02-01T01:00Z,2009-02-01T01:15Z,2009-02-01T01:30Z,2009-02-01T01:45Z > the first element is missing in the list (but not the separator). This is > caused by an off-by-one error introduced in OOZIE-2942. > > > Diffs > ----- > > examples/src/main/java/org/apache/oozie/example/DateList.java 731fe413 > examples/src/test/java/org/apache/oozie/example/TestDateList.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68180/diff/2/ > > > Testing > ------- > > > Thanks, > > Daniel Becker > >
