----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68411/#review207745 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Line 67 (original), 66 (patched) <https://reviews.apache.org/r/68411/#comment291250> `XTestCase` has its own `Services` field. Why do we need one more here? core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 540-542 (patched) <https://reviews.apache.org/r/68411/#comment291249> Why do we need this at all? Why not rely on `tearDown()` instead? - András Piros On Aug. 17, 2018, 1:36 p.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68411/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 1:36 p.m.) > > > Review request for oozie, András Piros, Kinga Marton, and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3264 - Flaky test > TestCoordMaterializeTransitionXCommand#testLastOnlyMaterialization > > > Diffs > ----- > > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > b784093b > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 8189732e > core/src/test/java/org/apache/oozie/test/XDataTestCase.java a8fe7037 > > > Diff: https://reviews.apache.org/r/68411/diff/1/ > > > Testing > ------- > > I was using grind. Before the modification it was failing 2 times out of 50 > executions, after the patch it works 50/50. > > > Thanks, > > Andras Salamon > >
