> On Aug. 22, 2018, 1:09 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > > Line 67 (original), 66 (patched) > > <https://reviews.apache.org/r/68411/diff/1/?file=2074591#file2074591line68> > > > > `XTestCase` has its own `Services` field. Why do we need one more here?
There is no field in XTestCase which could be used here, but Services.get() can be used instead of the local variable. > On Aug. 22, 2018, 1:09 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > > Lines 540-542 (patched) > > <https://reviews.apache.org/r/68411/diff/1/?file=2074591#file2074591line542> > > > > Why do we need this at all? Why not rely on `tearDown()` instead? This method requires real CallableQueueService instead of the fake one. This code was destroying the fake services and initializing the real services. Moved this method to a new class (TestCoordMaterializeTransitionXCommandWithRunningServices) where special handling is no longer necessary. - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68411/#review207745 ----------------------------------------------------------- On Aug. 17, 2018, 1:36 p.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68411/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 1:36 p.m.) > > > Review request for oozie, András Piros, Kinga Marton, and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3264 - Flaky test > TestCoordMaterializeTransitionXCommand#testLastOnlyMaterialization > > > Diffs > ----- > > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > b784093b > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 8189732e > core/src/test/java/org/apache/oozie/test/XDataTestCase.java a8fe7037 > > > Diff: https://reviews.apache.org/r/68411/diff/1/ > > > Testing > ------- > > I was using grind. Before the modification it was failing 2 times out of 50 > executions, after the patch it works 50/50. > > > Thanks, > > Andras Salamon > >
