[
https://issues.apache.org/jira/browse/OOZIE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589930#comment-16589930
]
Hadoop QA commented on OOZIE-3331:
----------------------------------
Testing JIRA OOZIE-3331
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
. {color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
error(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 2926
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/777/
> SparkOptionsSplitter inconsistency
> ----------------------------------
>
> Key: OOZIE-3331
> URL: https://issues.apache.org/jira/browse/OOZIE-3331
> Project: Oozie
> Issue Type: Test
> Components: action
> Affects Versions: 5.0.0
> Reporter: Andras Salamon
> Assignee: Andras Salamon
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: OOZIE-3331-1.patch, OOZIE-3331-wip.patch
>
>
> According to the [javadoc
> comment|https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java#L125-L138]
> of SparkOptionsSplitter we should unquote the option value if and only if
> it has quotes at both ends, and doesn't have any quotes in between. One of
> the listed examples shows that the following should remain quoted:
> {noformat}
> key="value1 value2" "value3 value4"{noformat}
> The current code unquotes this example which contradicts the javadoc comment.
> We should either change the javadoc or the code (after defining the correct
> behaviour) and we should also add a unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
