[
https://issues.apache.org/jira/browse/OOZIE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590165#comment-16590165
]
Andras Piros commented on OOZIE-3331:
-------------------------------------
Thanks for the contribution [~asalamon74]! +1
> SparkOptionsSplitter inconsistency
> ----------------------------------
>
> Key: OOZIE-3331
> URL: https://issues.apache.org/jira/browse/OOZIE-3331
> Project: Oozie
> Issue Type: Test
> Components: action
> Affects Versions: 5.0.0
> Reporter: Andras Salamon
> Assignee: Andras Salamon
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: OOZIE-3331-1.patch, OOZIE-3331-wip.patch
>
>
> According to the [javadoc
> comment|https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java#L125-L138]
> of SparkOptionsSplitter we should unquote the option value if and only if
> it has quotes at both ends, and doesn't have any quotes in between. One of
> the listed examples shows that the following should remain quoted:
> {noformat}
> key="value1 value2" "value3 value4"{noformat}
> The current code unquotes this example which contradicts the javadoc comment.
> We should either change the javadoc or the code (after defining the correct
> behaviour) and we should also add a unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
