----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67885/#review207864 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java Lines 140 (patched) <https://reviews.apache.org/r/67885/#comment291426> Should be using MIN_PRIORITY instead of 0 core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java Lines 243-261 (patched) <https://reviews.apache.org/r/67885/#comment291427> Would it be possible to eliminate the repeated code? Maybe create a new function and call it twice? core/src/main/java/org/apache/oozie/service/CallableQueueService.java Line 474 (original), 502 (patched) <https://reviews.apache.org/r/67885/#comment291435> Should be using PRIORITIES instead of 3 core/src/main/resources/oozie-default.xml Line 1 (original), 1 (patched) <https://reviews.apache.org/r/67885/#comment291468> What about adding oozie.service.CallableQueueService.queue.oldImpl property to the oozie-default.xml file? core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java Lines 282 (patched) <https://reviews.apache.org/r/67885/#comment291438> Message can be confusing if pendingCommandsPerType.size() returns > 1 (which is not very likely). - Andras Salamon On Aug. 17, 2018, 12:37 p.m., Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67885/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 12:37 p.m.) > > > Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert > Kanter. > > > Repository: oozie-git > > > Description > ------- > > See upstream JIRA for details > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/CallableQueueService.java > ef8d58da5 > core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c > core/src/main/resources/oozie-default.xml b69d2c9aa > core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java > PRE-CREATION > core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java > 9c2a11d6f > > > Diff: https://reviews.apache.org/r/67885/diff/8/ > > > Testing > ------- > > 1. Executed TestCallableQueueService which passed completely. > 2. New unit tests for ASyncXCommandExecutor. > 3. Tried it on a 3-node cluster > > > Thanks, > > Peter Bacsko > >
