----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69594/ -----------------------------------------------------------
(Updated Dec. 21, 2018, 3:17 p.m.) Review request for oozie, András Piros and Kinga Marton. Changes ------- I'm checking for infinite loop in the tree. I have introduced a new error code if I find one. I wanted to use LinkedHashSet, but index based get was not working so I use a separete Set for the checking. I refactored the new functionality in a nested class but the test was so workflow-specific that I ended up creating a generic-based version. It might be an overkill. Repository: oozie-git Description ------- OOZIE-3400: Fix PurgeService sub-sub-workflow checking Diffs (updated) ----- core/src/main/java/org/apache/oozie/ErrorCode.java 9cc153bb0 core/src/main/java/org/apache/oozie/command/PurgeXCommand.java 42c3b28a6 core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java d11fcffbb core/src/test/java/org/apache/oozie/command/TestSelectorTreeTraverser.java PRE-CREATION Diff: https://reviews.apache.org/r/69594/diff/2/ Changes: https://reviews.apache.org/r/69594/diff/1-2/ Testing ------- Run TestPurgeXCommand unit tests locally. Thanks, Andras Salamon
