> On Dec. 21, 2018, 4:21 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
> > Lines 256 (patched)
> > <https://reviews.apache.org/r/69594/diff/2/?file=2115651#file2115651line256>
> >
> >     Can we express it JDK7-like? Maybe using [Guava's 
> > `Function`](https://github.com/google/guava/wiki/FunctionalExplained)?

I was not using java.util.function only language elements like lambda and 
method reference. Converted to anonymous classes.


> On Dec. 21, 2018, 4:21 p.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/TestSelectorTreeTraverser.java
> > Lines 37-61 (patched)
> > <https://reviews.apache.org/r/69594/diff/2/?file=2115653#file2115653line37>
> >
> >     Can we express it JDK7-like? Maybe using [Guava's 
> > `Function`](https://github.com/google/guava/wiki/FunctionalExplained)?

Converted to anonymous classes


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69594/#review211500
-----------------------------------------------------------


On Dec. 21, 2018, 3:17 p.m., Andras Salamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69594/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2018, 3:17 p.m.)
> 
> 
> Review request for oozie, András Piros and Kinga Marton.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-3400: Fix PurgeService sub-sub-workflow checking
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 9cc153bb0 
>   core/src/main/java/org/apache/oozie/command/PurgeXCommand.java 42c3b28a6 
>   core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java 
> d11fcffbb 
>   core/src/test/java/org/apache/oozie/command/TestSelectorTreeTraverser.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69594/diff/2/
> 
> 
> Testing
> -------
> 
> Run TestPurgeXCommand unit tests locally.
> 
> 
> Thanks,
> 
> Andras Salamon
> 
>

Reply via email to