> On Feb. 11, 2019, 2:23 p.m., Kinga Marton wrote: > > core/src/main/java/org/apache/oozie/util/ELEvaluator.java > > Lines 205-209 (original), 210-214 (patched) > > <https://reviews.apache.org/r/69783/diff/2/?file=2122831#file2122831line211> > > > > As I can see the evaluator.evaluate can throw > > javax.servlet.jsp.el.ELException, but in the catch part you are checking if > > the thrown exception is javax.el.ELException. Is this a bug or I am missing > > something?
We have discussed it in person but I write it down, maybe it will be useful later. The method can throw the checked javax.servlet.jsp.el.ELException but in the real life it will throw a RuntimeException which is very confusedly named javax.el.ELException. So we really need to catch that one. It will be better to catch RuntimeException instead to prepare for other RuntimeExceptions. - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69783/#review212604 ----------------------------------------------------------- On Jan. 28, 2019, 7:32 a.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69783/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2019, 7:32 a.m.) > > > Review request for oozie, András Piros and Kinga Marton. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3409 - Oozie Server : Memory leak in EL evaluation > > > Diffs > ----- > > core/pom.xml b6c07d345 > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > c1c644459 > core/src/main/java/org/apache/oozie/util/ELEvaluator.java 90d79779f > core/src/main/java/org/apache/oozie/util/StringUtils.java 26079be93 > core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java > 519b38406 > core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 04a869c0b > core/src/test/java/org/apache/oozie/util/TestStringUtils.java 423d6be27 > examples/pom.xml 8900535b2 > pom.xml 93fffc791 > > > Diff: https://reviews.apache.org/r/69783/diff/2/ > > > Testing > ------- > > Using grind to execute unit tests. > Using CDH cluster to create lots of dynamic workflows. > > > Thanks, > > Andras Salamon > >
