> On Feb. 11, 2019, 2:23 p.m., Kinga Marton wrote: > > core/src/main/java/org/apache/oozie/util/ELEvaluator.java > > Lines 148 (patched) > > <https://reviews.apache.org/r/69783/diff/2/?file=2122831#file2122831line149> > > > > org.apache.jasper.el.ExpressionEvaluatorImpl is deprecated. Does it > > have a replacement? If yes, let's use the replacement instead of the > > deprecated class.
I found this info: Description copied from class: javax.servlet.jsp.el.ExpressionEvaluator In that class the following info: As of JSP 2.1, replaced by javax.el.ExpressionFactory But ExpressionFactory has no parseExpression method. So i don't really know which non-deprecated class we should use. Jetty 9.3 also uses these classes, so I don't think it's a bug problem. Maybe when we upgrade Jetty, JSP at the same time, we should also update apache-jsp and revisit this issue. - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69783/#review212604 ----------------------------------------------------------- On Jan. 28, 2019, 7:32 a.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69783/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2019, 7:32 a.m.) > > > Review request for oozie, András Piros and Kinga Marton. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3409 - Oozie Server : Memory leak in EL evaluation > > > Diffs > ----- > > core/pom.xml b6c07d345 > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > c1c644459 > core/src/main/java/org/apache/oozie/util/ELEvaluator.java 90d79779f > core/src/main/java/org/apache/oozie/util/StringUtils.java 26079be93 > core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java > 519b38406 > core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 04a869c0b > core/src/test/java/org/apache/oozie/util/TestStringUtils.java 423d6be27 > examples/pom.xml 8900535b2 > pom.xml 93fffc791 > > > Diff: https://reviews.apache.org/r/69783/diff/2/ > > > Testing > ------- > > Using grind to execute unit tests. > Using CDH cluster to create lots of dynamic workflows. > > > Thanks, > > Andras Salamon > >
