----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70042/#review213221 -----------------------------------------------------------
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Line 490 (original), 490 (patched) <https://reviews.apache.org/r/70042/#comment299093> Could you please add @VisibleForTesting sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 22 (patched) <https://reviews.apache.org/r/70042/#comment299094> Do we really use this class? sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 402-403 (patched) <https://reviews.apache.org/r/70042/#comment299097> Could be private sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 415 (patched) <https://reviews.apache.org/r/70042/#comment299095> Unfortunately we use a mixture of Junit3, Junit4. To make it very clear that this is not a test method, just a helper method called by other test methods I would choose an other prefix instead of 'test'. It could also be private sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 417-418 (patched) <https://reviews.apache.org/r/70042/#comment299098> Can you extract the Configuration variable. We need to break the long line anyway. sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 422-423 (patched) <https://reviews.apache.org/r/70042/#comment299099> Can you extract the Configuration variable. We need to break the long line anyway. sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 432 (patched) <https://reviews.apache.org/r/70042/#comment299100> Couldn't we remove the new URI[] part? Like Arrays.asList(new Path(LOCAL_FILE).toUri(), new Path(HDFS_FILE).toUri()) sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 454 (patched) <https://reviews.apache.org/r/70042/#comment299096> Couldn't we use equals instead of startsWith? sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 461 (patched) <https://reviews.apache.org/r/70042/#comment299101> If neither positive nor negative is present, then the assertTrue above should give us an error. If I understand correctly we reach this fail if the collection has no --files / --archives item. - Andras Salamon On Feb. 25, 2019, 12:42 p.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70042/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2019, 12:42 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3440 > https://issues.apache.org/jira/browse/OOZIE-3440 > > > Repository: oozie-git > > > Description > ------- > > Failing Oozie Launcher, Main class > [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File > file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 28d9c5cc4 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 7ccd26ad5 > > > Diff: https://reviews.apache.org/r/70042/diff/2/ > > > Testing > ------- > > Unit tests run > > > Thanks, > > Denes Bodo > >
