----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70042/#review213151 -----------------------------------------------------------
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 491 (patched) <https://reviews.apache.org/r/70042/#comment299012> Please create a unit test for this method sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 492 (patched) <https://reviews.apache.org/r/70042/#comment299013> Null pointer check would be useful here. sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 493 (patched) <https://reviews.apache.org/r/70042/#comment299014> Please add a space after "for" and later after "if" sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 397 (patched) <https://reviews.apache.org/r/70042/#comment299011> It seems to me you both modified --files and --archives options. Could you please also test --archives. sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 398 (patched) <https://reviews.apache.org/r/70042/#comment299010> There are two ways to specify the files: --files xxxx --files=xxxx Could you please also test the second type. sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 405 (patched) <https://reviews.apache.org/r/70042/#comment299007> It would be better to use different file names for the non-hdfs and hdfs version. Using the same name might result strange problems. sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 410-414 (patched) <https://reviews.apache.org/r/70042/#comment299002> I think it would be possible to create better assertions here without converting the List<String> to String. Could you please also add assert messages. - Andras Salamon On Feb. 22, 2019, 1:28 p.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70042/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2019, 1:28 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3440 > https://issues.apache.org/jira/browse/OOZIE-3440 > > > Repository: oozie-git > > > Description > ------- > > Failing Oozie Launcher, Main class > [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File > file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 28d9c5cc4 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 7ccd26ad5 > > > Diff: https://reviews.apache.org/r/70042/diff/1/ > > > Testing > ------- > > Unit tests run > > > Thanks, > > Denes Bodo > >
