----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66656/#review213472 -----------------------------------------------------------
Please use final modifier where possible in the new code. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 1164-1165 (patched) <https://reviews.apache.org/r/66656/#comment299404> In case of an error wi shall throw an exception. It this is not a real error, then I think we should use WARN level. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 1173 (patched) <https://reviews.apache.org/r/66656/#comment299405> Are you sure it is not WARN? core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 1177 (patched) <https://reviews.apache.org/r/66656/#comment299406> Are you sure it is not WARN? core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java Lines 46 (patched) <https://reviews.apache.org/r/66656/#comment299407> ... pattern is not ... core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java Lines 62 (patched) <https://reviews.apache.org/r/66656/#comment299411> maybeExcludePattern can be final core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java Lines 64 (patched) <https://reviews.apache.org/r/66656/#comment299410> excludePattern can be final core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java Lines 74 (patched) <https://reviews.apache.org/r/66656/#comment299408> please be consistent with *final* modifier in parameter list. Use it everywhere or use nowhere. core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java Lines 86 (patched) <https://reviews.apache.org/r/66656/#comment299409> What does "skipping" mean? I would like to see a bit more detailed message what hapens this case. core/src/main/java/org/apache/oozie/service/ShareLibService.java Lines 624 (patched) <https://reviews.apache.org/r/66656/#comment299412> What can cause that IOException? core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutorLibAddition.java Lines 431 (patched) <https://reviews.apache.org/r/66656/#comment299403> please remove trailing whitespaces - Denes Bodo On March 5, 2019, 4:54 p.m., Mate Juhasz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66656/ > ----------------------------------------------------------- > > (Updated March 5, 2019, 4:54 p.m.) > > > Review request for oozie, András Piros and Denes Bodo. > > > Bugs: OOZIE-1624 > https://issues.apache.org/jira/browse/OOZIE-1624 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1624 Exclusion pattern for sharelib. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 231b38ea > core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/ShareLibService.java b88dab3a > > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 05511e4c > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 6383e814 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutorLibAddition.java > PRE-CREATION > core/src/test/java/org/apache/oozie/action/hadoop/TestShareLibExcluder.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66656/diff/7/ > > > Testing > ------- > > Tested on a cluster > > > Thanks, > > Mate Juhasz > >
