[
https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650413#comment-17650413
]
Janos Makai commented on OOZIE-3479:
------------------------------------
Using GitHub actions seems to have great potential and I think that could help
simplifying the PreCommit system for the Github PRs.
With that we can easily execute the build process and running the unit tests as
@Gézapeti mentioned.
The main concern @Gézapeti raised is that there might be a problem acquiring
the changes of the PR. One direction that looks promising is that we could
gather all the changed files corresponding to a PR using a changed files
gathering GitHub action, and then we could launch our scripts against those
files in the container (e.g. SpotBugs, RAW patch analysis, backward
compatibility checks, etc..) Examples of this can be found here:
[LINK|https://github.com/marketplace/actions/changed-files] and here:
[LINK|https://docs.github.com/en/actions/examples/using-scripts-to-test-your-code-on-a-runner]
What do you think of this approach?
> Build pre-commit pipeline for pull requests.
> --------------------------------------------
>
> Key: OOZIE-3479
> URL: https://issues.apache.org/jira/browse/OOZIE-3479
> Project: Oozie
> Issue Type: Task
> Reporter: Gézapeti
> Priority: Major
>
> I think it would be great to accept pull requests for Oozie as well.
> We should build the pre-commit system out first to see how it works for us
> before updating the site and changing the rules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
