Hi Kevan, Many thanks for looking at this and pointing out these issues. I'll cancel this vote, and try again.
Regarding point 4 - pretty much all of the content in the LICENSE and NOTICE files is the same as the files in OpenEJB itself, as the dependencies are the same. Presumably that means we have potentially the same issue with OpenEJB itself ( https://svn.apache.org/repos/asf/openejb/trunk/openejb3/assembly/openejb-standalone/src/main/resources/NOTICE.txtfor example)? Jon On Tue, Sep 22, 2009 at 2:53 PM, Kevan Miller <[email protected]>wrote: > Apologies for my delay... > > -1 for the following reasons: > > 1. There should be a LICENSE and NOTICE file in the > https://svn.apache.org/repos/asf/openejb/tags/eclipse-plugins-1.0.0.alpha/ > directory > 2. I don't see a source archive for the release. My current understanding > is that this is a requirement for Apache releases. > 3. plugin jars have two sets of license/notice files (e.g. LICENSE and > META-INF/LICENSE). The files are different (I believe LICENSE and NOTICE are > correct). License/notice info should only be in META-INF/LICENSE and > META-INF/NOTICE. > 4. Current ASF convention is to have minimal NOTICE files. This means not > having comments like: > > ========================================================================= > == NOTICE file corresponding to section 4(d) of the Apache License, == > == Version 2.0, in this case for the Apache OpenEJB distribution. == > ========================================================================= > or > ========================================================================= > == Swizzle Stream Notice == > ========================================================================= > > Personally, I'm not sure that point 4 is a blocking issue, but there are > some in the ASF that might argue otherwise... > > --kevan > > > On Sep 13, 2009, at 3:00 PM, Jonathan Gallimore wrote: > > Thanks very much for the feedback so far. I've built a new release of the >> plugin with the update site URL corrected and a couple of license headers >> fixed. >> >> We do have one issue which is the update site is hard coded to >> http://people.apache.org/~jgallimore/test3/update-site/<http://people.apache.org/%7Ejgallimore/test3/update-site/>which >> will need to >> change for the actual release to wherever the actual update site ends up >> being, if anyone knows a solution to this I'd be grateful for the help, >> otherwise we might have to live with this being hardcoded for the time >> being. >> >> Anyway, I thought I'd go for a vote, so here goes: >> >> The binaries are available here: >> http://people.apache.org/~jgallimore/test3/<http://people.apache.org/%7Ejgallimore/test3/> >> >> The update site is here: >> http://people.apache.org/~jgallimore/test3/update-site/<http://people.apache.org/%7Ejgallimore/test3/update-site/> >> >> The Maven staging repository is here: >> https://repository.apache.org/content/repositories/openejb-014/ >> >> The 1.0.0.alpha branch is here: >> >> https://svn.apache.org/repos/asf/openejb/branches/eclipse-plugins-1.0.0.alpha/ >> >> and the tag of this release is here: >> https://svn.apache.org/repos/asf/openejb/tags/eclipse-plugins-1.0.0.alpha/ >> >> The vote will be open for at least 72 hours, and probably a bit longer as >> this is a first attempt at a release for the plugin, and we tend to have >> longer votes. >> >> Here's my +1, I've tested the installation and execution on Eclipse 3.3, >> 3.4 >> and 3.5 on Ubuntu 9.04. >> >> Jon >> > >
