On May 5, 2010, at 2:29 PM, Jonathan Gallimore wrote:

> I've done some more hacking around with the names of the
> generated proxies so they are more meaningful and also created an
> AppClassLoader which is a simple extension of URLClassLoader that can have
> extra classes added to it. I've wired this into ClassLoaderUtil so each app
> should have an AppClassLoader, and generated proxies are added to the class
> loader for the relevant application.

I recently stumbled across the sun.misc.Unsafe.defineClass().  I bet that's 
what the VM Proxy stuff uses.  Looks like we could avoid the AppClassLoader 
stuff altogether.

We use Unsafe plenty of places already.  Although it's in "sun.misc" it's a 
critical and standardly supported class.

> I'll attach another patch to the JIRA with these changes. If its ok, I'll
> get this committed. Currently my build passes with no test failures and the
> itests pass as well.

Go for it!  Commit away.

>> 
>> Anyway, fantastic development!
>> 
> 
> Thanks for all your feedback David, and thanks for the opportunity to work
> on this functionality - I've had a lot of fun working on it, and I've learnt
> an awful lot.

Hehe. Somehow saying "you're welcome for doing all the work" doesn't sound 
right :)  Of course all the thanks goes to you!

I'm super excited about all the fun stuff everyone's working on.  We have 
ourselves a real great community.

-David

Reply via email to