On Oct 16, 2010, at 11:41 AM, dsh wrote: > Out of curiosity cause I don't know the answer at the top off my head > - how to vote if the test case is rather broken and not the code to be > tested like in this case where there was a minor glitch in XMLUnit if > I get it correct?
Given the number of re-rolls, I think the vote needs to continue until we find a more critical issue. If at the end of the vote this is the only issue, we can decide as a group how to proceed. Definitely I don't want to re-roll so many times that people feel pressure to vote +1 even if they find an issue like this. -David > > On Sat, Oct 16, 2010 at 8:36 PM, dsh <[email protected]> wrote: >> +1 >> >> Built and ran tests on the following platforms (did a fresh SVN >> checkout prior to each build): >> >> MacBook Pro (Snow Leopard): Apple JDK6 / Maven3 / 64Bits << success >> ThinkPad (Fedora Core 13): IBM JDK6 / Maven3 / 64Bits << success >> ThinkPad (Windoze XP Pro): IBM JDK6 / Maven3 / 32Bits << failure >> (should be fixed according to Andy) >> >> ------------------------------------------------------------------------------- >> Test set: org.apache.openejb.config.OpenEjb2ConversionTest >> ------------------------------------------------------------------------------- >> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: >> 19.213 sec <<< FAILURE! >> testSimple(org.apache.openejb.config.OpenEjb2ConversionTest) Time >> elapsed: 7.505 sec <<< FAILURE! >> junit.framework.AssertionFailedError: Files are similar >> org.custommonkey.xmlunit.Diff >> [different] Expected text value 'module.property.b=valueb >> module.property.a=valuea >> ' but was 'module.property.b=valueb >> module.property.a=valuea >> ' - comparing <properties ...>module.property.b=valueb >> module.property.a=valuea >> </properties> at /openejb-jar[1]/properties[1]/text()[1] to >> <properties ...>module.property.b=valueb >> module.property.a=valuea >> </properties> at /openejb-jar[1]/properties[1]/text()[1] >> >> at junit.framework.Assert.fail(Assert.java:47) >> at junit.framework.Assert.assertTrue(Assert.java:20) >> at >> org.apache.openejb.config.OpenEjb2ConversionTest.assertJaxb(OpenEjb2ConversionTest.java:110) >> at >> org.apache.openejb.config.OpenEjb2ConversionTest.testSimple(OpenEjb2ConversionTest.java:50) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >> at java.lang.reflect.Method.invoke(Method.java:600) >> at junit.framework.TestCase.runTest(TestCase.java:168) >> at junit.framework.TestCase.runBare(TestCase.java:134) >> at junit.framework.TestResult$1.protect(TestResult.java:110) >> at junit.framework.TestResult.runProtected(TestResult.java:128) >> at junit.framework.TestResult.run(TestResult.java:113) >> at junit.framework.TestCase.run(TestCase.java:124) >> at junit.framework.TestSuite.runTest(TestSuite.java:232) >> at junit.framework.TestSuite.run(TestSuite.java:227) >> at >> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79) >> at >> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) >> at >> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) >> at >> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:165) >> at org.apache.maven.surefire.Surefire.run(Surefire.java:107) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >> at java.lang.reflect.Method.invoke(Method.java:600) >> at >> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:289) >> at >> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:993) >> >> ThinkPad (Windoze 7): IBM JDK6 / Maven3 / 64Bits << failure (should be >> fixed according to Andy) >> >> ------------------------------------------------------------------------------- >> Test set: org.apache.openejb.config.OpenEjb2ConversionTest >> ------------------------------------------------------------------------------- >> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 43.59 >> sec <<< FAILURE! >> testSimple(org.apache.openejb.config.OpenEjb2ConversionTest) Time >> elapsed: 19.115 sec <<< FAILURE! >> junit.framework.AssertionFailedError: Files are similar >> org.custommonkey.xmlunit.Diff >> [different] Expected text value 'module.property.b=valueb >> module.property.a=valuea >> ' but was 'module.property.b=valueb >> module.property.a=valuea >> ' - comparing <properties ...>module.property.b=valueb >> module.property.a=valuea >> </properties> at /openejb-jar[1]/properties[1]/text()[1] to >> <properties ...>module.property.b=valueb >> module.property.a=valuea >> </properties> at /openejb-jar[1]/properties[1]/text()[1] >> >> at junit.framework.Assert.fail(Assert.java:47) >> at junit.framework.Assert.assertTrue(Assert.java:20) >> at >> org.apache.openejb.config.OpenEjb2ConversionTest.assertJaxb(OpenEjb2ConversionTest.java:110) >> at >> org.apache.openejb.config.OpenEjb2ConversionTest.testSimple(OpenEjb2ConversionTest.java:50) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >> at java.lang.reflect.Method.invoke(Method.java:600) >> at junit.framework.TestCase.runTest(TestCase.java:168) >> at junit.framework.TestCase.runBare(TestCase.java:134) >> at junit.framework.TestResult$1.protect(TestResult.java:110) >> at junit.framework.TestResult.runProtected(TestResult.java:128) >> at junit.framework.TestResult.run(TestResult.java:113) >> at junit.framework.TestCase.run(TestCase.java:124) >> at junit.framework.TestSuite.runTest(TestSuite.java:232) >> at junit.framework.TestSuite.run(TestSuite.java:227) >> at >> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79) >> at >> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) >> at >> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) >> at >> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:165) >> at org.apache.maven.surefire.Surefire.run(Surefire.java:107) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >> at java.lang.reflect.Method.invoke(Method.java:600) >> at >> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:289) >> at >> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:993) >> >> You want me to add anything else to this operating system & platform >> zoo, I could test on these but I doubt I'll be able to claim success >> ;) >> >> IntelliStation z pro (FreeBSD 6.3): Sun JDK6 / Maven3 / 32Bits >> IntelliStation z pro (Ubuntu Karmic): OpenJDK6 / Maven3 / 32Bits >> >> Cheers >> Daniel >> >> On Sat, Oct 16, 2010 at 5:17 AM, David Blevins <[email protected]> >> wrote: >>> Round 3, up and ready. >>> >>> Repo: >>> >>> https://repository.apache.org/content/repositories/orgapacheopenejb-005/ >>> >>> Binaries: >>> >>> http://people.apache.org/~dblevins/staging-005/3.1.3/ >>> >>> Branch (to become a tag): >>> >>> http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.3/ >>> >>> Rat log: >>> >>> http://people.apache.org/~dblevins/staging-005/rat.log >>> http://people.apache.org/~dblevins/staging-005/rat.xml (ant script with >>> excludes) >>> >>> To run the itests: >>> >>> http://people.apache.org/~dblevins/staging-005/build.xml >>> >>> >>> -David >>> >>> >>> >>> >> >
