On 16.10.2010 21:53, David Blevins wrote:
On Oct 16, 2010, at 11:34 AM, Andy wrote:

On 16.10.2010 05:17, David Blevins wrote:
Round 3, up and ready.

Repo:

   https://repository.apache.org/content/repositories/orgapacheopenejb-005/

Binaries:

   http://people.apache.org/~dblevins/staging-005/3.1.3/

Branch (to become a tag):

   http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.3/

Rat log:

   http://people.apache.org/~dblevins/staging-005/rat.log
   http://people.apache.org/~dblevins/staging-005/rat.xml (ant script with 
excludes)

To run the itests:

   http://people.apache.org/~dblevins/staging-005/build.xml


-David





-1

Andy.

I have fixed this test in trunk - It is just a carriage return issue and the 
way xmlunit handles them.
Definitely keep evaluating and post if you find anything else.

If you can check your trunk fix into the 3.1.x branch, that'd be great!

-David


-------------------------------------------------------------------------------
Test set: org.apache.openejb.config.OpenEjb2ConversionTest
-------------------------------------------------------------------------------
Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.122 sec<<<  
FAILURE!
testSimple(org.apache.openejb.config.OpenEjb2ConversionTest)  Time elapsed: 0.994 
sec<<<  FAILURE!
junit.framework.AssertionFailedError: Files are similar 
org.custommonkey.xmlunit.Diff
[different] Expected text value 'module.property.b=valueb
module.property.a=valuea
' but was 'module.property.b=valueb
module.property.a=valuea
' - comparing<properties ...>module.property.b=valueb
module.property.a=valuea
</properties>  at /openejb-jar[1]/properties[1]/text()[1] to<properties 
...>module.property.b=valueb
module.property.a=valuea
</properties>  at /openejb-jar[1]/properties[1]/text()[1]

    at junit.framework.Assert.fail(Assert.java:47)
    at junit.framework.Assert.assertTrue(Assert.java:20)
    at 
org.apache.openejb.config.OpenEjb2ConversionTest.assertJaxb(OpenEjb2ConversionTest.java:110)
    at 
org.apache.openejb.config.OpenEjb2ConversionTest.testSimple(OpenEjb2ConversionTest.java:50)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at junit.framework.TestCase.runTest(TestCase.java:168)
    at junit.framework.TestCase.runBare(TestCase.java:134)
    at junit.framework.TestResult$1.protect(TestResult.java:110)
    at junit.framework.TestResult.runProtected(TestResult.java:128)
    at junit.framework.TestResult.run(TestResult.java:113)
    at junit.framework.TestCase.run(TestCase.java:124)
    at junit.framework.TestSuite.runTest(TestSuite.java:232)
    at junit.framework.TestSuite.run(TestSuite.java:227)
    at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79)
    at 
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
    at 
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
    at 
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:165)
    at org.apache.maven.surefire.Surefire.run(Surefire.java:107)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at 
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:289)
    at 
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:993)




+1

Done.

Andy

Reply via email to