I haven't had a chance to check it out yet, but I definitely appreciate your efforts - many thanks! Not quite sure what "do i let you the surprise of the solution i used?" means, but I'll definitely check out your solution and make sure I understand it :-).
Thanks Jon On Fri, Oct 28, 2011 at 2:09 PM, Romain Manni-Bucau <[email protected]>wrote: > your remote test case works > > do i let you the surprise of the solution i used? > > - Romain > > > 2011/10/28 Romain Manni-Bucau <[email protected]> > > > i'm making it working in embedded mode now, just some minute to let me > > commited > > > > PS: i really would like to avoid to contribute our own enricher if it is > > not something directly linked to openejb > > > > - Romain > > > > > > > > 2011/10/28 Jonathan Gallimore <[email protected]> > > > >> On Fri, Oct 28, 2011 at 1:27 PM, Romain Manni-Bucau > >> <[email protected]>wrote: > >> > >> > @RunAsClient = @Deployment(testable = false) (personnally i prefer the > >> > first > >> > one but i don't really care ;)) > >> > > >> > if one of both is not true then the EJBInjectionEnricher is not > called. > >> > > >> > One way to avoid it is to use "Local" protocol instead of "servlet > 3.0" > >> in > >> > our container. > >> > > >> > > >> I think we need to make sure this works for the > @Deployment(testable=true) > >> without @RunAsClient case as well. It doesn't for me at the moment - > this > >> seems to be how a lot of the tests are setup in the showcase. > >> > >> When I've been running this, my experience is the Arquillian EJB > enricher > >> is > >> called, but can't inject the bean (it can't lookup java:global, and the > >> global names we deploy are different to what it expects to see), hence > the > >> code I added to the remote adapter. I'm happy to show you this on a > screen > >> share if you like. > >> > >> > >> > >> > I prefer to avoid to copy paste existing code. > >> > > >> > >> +1. How about moving the enricher code to the common module? > >> > >> > >> > > >> > i'll try to connect this evening or tmr to help you on this point. > >> > > >> > >> Thanks, I really appreciate it. I'm busy due to another commitment this > >> evening, but I'll be working on this and rehearsing for JAX all weekend. > >> > >> > >> > > >> > Maybe we can start forking arquillian showcase on github (i think you > >> had > >> > an > >> > account?) > >> > > >> > >> +1. I do have a github a/c (jgallimore) and I have a fork of this on > there > >> already. We ought to update the poms and arquillian .xml files and > figure > >> out if there's any gaps. > >> > >> Cheers > >> > >> Jon > >> > > > > >
