On 6/19/07, Michael Dick <[EMAIL PROTECTED]> wrote:
Hi Catalina, Comments below. On 6/19/07, catalina wei <[EMAIL PROTECTED]> wrote: > > Dave Wisneski and I propose to do packaging cleanup for OPENJPA-240 as the > following: > 1. remove openjpa-xmlmapping-5 +1 2. rename package org.apache.openjpa.xmlmapping to > org.apache.openjpa.jdbc.xmlmapping If it were me I would move the XMLValueHandler class to package org.apache.openjpa.jdbc.meta.strats with the rest of the ValueHandlers. The main reason is to keep similar classes grouped together, but I think it would also help to avoid confusion between the package and the openjpa-xmlmapping module.
It is a matter of having user to specify on @Strategy with a long name " org.apache.openjpa.jdbc.meta.strats.XMLValueHandler" vs. a shorter name. "org.apache.openjpa.jdbc.xmlmapping.XMLValueHandler" I believe the strategies under org.apache.openjpa.jdbc.meta.strats are openjpa's default strategies, i.e., jpa entities need not explicitly specify using @Strategy annotation. Catalina and place it under openjpa-jdbc source directory
> 3. rename XmlValueHandler as XMLValueHandler. +1 Is this acceptable ? > Catalina Other than the issue noted above I think this looks good. -Mike On 6/19/07, Abe White <[EMAIL PROTECTED]> wrote: > > > > I haven't looked at your code at all, but as an aside, we > > consistently use all caps for acronyms in our internal code: JDBC not > > Jdbc, URL not Url, and XML not Xml. > > > > > > Notice: This email message, together with any attachments, may contain > > information of BEA Systems, Inc., its subsidiaries and affiliated > > entities, that may be confidential, proprietary, copyrighted and/or > > legally privileged, and is intended solely for the use of the individual > or > > entity named in this message. If you are not the intended recipient, and > > have received this message in error, please immediately return this by > email > > and then delete it. > > >
