[
https://issues.apache.org/jira/browse/OPENJPA-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667392#action_12667392
]
Michael Dick commented on OPENJPA-849:
--------------------------------------
I haven't thoroughly reviewed the patch. A couple of comments though.
1. Moving to a Map <String,Object> is better than using a Properties object and
was overdue. Thanks for straightening it out.
2. openjpa-lib is not aware of Broker and Factory details, which are provided
in openjpa-kernel. Methods like propertiesSupportedOnEMF and
propertiesSupportedOnEM should be introduced in the kernel module (and renamed
to be Broker and BrokerFactory). Currently we don't have a configuration object
at this level so we might need to introduce one, or move the existing classes.
3. I see "openjpa" hardcoded as the prefix for a lot of properties. How would
this work for products that define their own configuration prefix? I believe
Kodo and WebSphere do this for some properties. Might just be a simple matter
of calling getConfigurationPrefix instead of hardcoding "openjpa".
That's it for now, the patch looks promising but it needs a little more polish
(IMHO). Thanks Dianne!
> Add metadata-type getter methods to EntityManager
> -------------------------------------------------
>
> Key: OPENJPA-849
> URL: https://issues.apache.org/jira/browse/OPENJPA-849
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Dianne Richards
> Assignee: Dianne Richards
> Attachments: patch.txt
>
>
> This task is for supporting the new 2.0 EntityManager methods getProperties()
> and getSupportedProperties()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
