[
https://issues.apache.org/jira/browse/OPENJPA-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669008#action_12669008
]
Jeremy Bauer commented on OPENJPA-849:
--------------------------------------
Thanks for submitting a revised patch and nice work! I reviewed the code
changes and have a couple minor issues/suggestions.
1) There is a possibility that the population of _supportedPropertyNames in
method getSupportedProperties() in AbstractBrokerFactory could lead to a race
condition if multiple threads were to call this method simultaneously. Since
the EMF is required to be thread, I recommend synchronizing the code (null
check, synch, null check, load) that loads the set to avoid a potential race
condition.
2) Some of the comments in the kernel code refer to the EM and EMF. While the
new function was added specifically for JPA, the broker and broker factory
should not refer to the facade.
> Add metadata-type getter methods to EntityManager
> -------------------------------------------------
>
> Key: OPENJPA-849
> URL: https://issues.apache.org/jira/browse/OPENJPA-849
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Dianne Richards
> Assignee: Dianne Richards
> Attachments: patch.txt, patch.txt
>
>
> This task is for supporting the new 2.0 EntityManager methods getProperties()
> and getSupportedProperties()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
