I'd give it a test run. I upgraded to a snapshot version of commons-pool. There is a workaround for the problems in this version though: to increase maxIdle to something higher than 0; That would be a sane default anyway.
Will try to fix that over the weekend and go back to the releaed commons-dbcp version. Then I'm fine to go. LieGrue, strub > Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <ilgro...@apache.org>: > > On 04/12/18 13:25, Maxim Solodovnik wrote: >> Additionally some classes are being used without "import" (to have same name) > > Yep: > > $ grep -r "commons\.collections" | grep "\.java" | sed 's/.*://' | sed > 's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' | > sort | uniq > org.apache.commons.collections4.bidimap.TreeBidiMap; > org.apache.commons.collections4.comparators.ComparableComparator; > org.apache.commons.collections4.comparators.ComparatorChain; > org.apache.commons.collections4.functors.,org.apache.xalan")), > org.apache.commons.collections4.iterators.EmptyIterator; > org.apache.commons.collections4.iterators.FilterIterator; > org.apache.commons.collections4.iterators.IteratorChain; > org.apache.commons.collections4.map. > org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength; > org.apache.commons.collections4.map.LinkedMap; > org.apache.commons.collections4.map.LRUMap > org.apache.commons.collections4.map.ReferenceMap > org.apache.commons.collections4.map.ReferenceMap; > org.apache.commons.collections4.Predicate; > org.apache.commons.collections4.set.MapBackedSet; > >> On Tue, 4 Dec 2018 at 18:42, Francesco Chicchiriccò <ilgro...@apache.org> >> wrote: >> >>> This is the list of classes from commons-collections4 we're depending on >>> ATM: >>> >>> ~/work/openjpa$ grep -r commons.collections | grep import | sed >>> 's/.*://' | sort | uniq >>> import org.apache.commons.collections4.bidimap.TreeBidiMap; >>> import org.apache.commons.collections4.comparators.ComparableComparator; >>> import org.apache.commons.collections4.comparators.ComparatorChain; >>> import org.apache.commons.collections4.iterators.EmptyIterator; >>> import org.apache.commons.collections4.iterators.FilterIterator; >>> import org.apache.commons.collections4.iterators.IteratorChain; >>> import >>> org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength; >>> import org.apache.commons.collections4.map.LinkedMap; >>> import org.apache.commons.collections4.map.ReferenceMap; >>> import org.apache.commons.collections4.Predicate; >>> import org.apache.commons.collections4.set.MapBackedSet; >>> >>> Not many, actually... >>> >>> On 04/12/18 10:55, Maxim Solodovnik wrote: >>>> I'm afraid the one who will drop commons-collections should have better >>>> code-understanding than I'm :( >>>> >>>> Here is the link to the discussion: >>>> >>> https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd4241ab3ae6a39d6b35e577b@%3Cuser.commons.apache.org%3E >>>> You can raise your voice :) >>>> >>>> On Mon, 3 Dec 2018 at 22:10, Romain Manni-Bucau <rmannibu...@gmail.com> >>>> wrote: >>>> >>>>> Does the cost to drop it is that high? Really tempted to say it is a >>> better >>>>> solution for openjpa anyway on the mid term. >>>>> >>>>> Le lun. 3 déc. 2018 à 16:08, Maxim Solodovnik <solomax...@gmail.com> a >>>>> écrit : >>>>> >>>>>> I did ping commons-collwctions community (~6 days ago) - no answer >>>>>> Will ping again >>>>>> >>>>>> On Mon, 3 Dec 2018 at 18:54, Francesco Chicchiriccò < >>> ilgro...@apache.org >>>>>> wrote: >>>>>> >>>>>>> Hi, >>>>>>> did we make any progress? >>>>>>> >>>>>>> FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400 >>>>>>> >>>>>>> Regards. >>>>>>> >>>>>>> On 26/11/18 14:07, Maxim Solodovnik wrote: >>>>>>>> Additionally commons-collections4 release is required >>>>>>>> I'll ping commons community .... >>>>>>>> >>>>>>>> On Mon, 26 Nov 2018 at 20:01, Francesco Chicchiriccò < >>>>>>> ilgro...@apache.org> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi there, >>>>>>>>> am I correct if I think that, once commons-pool2 and commons-dbcp2 >>>>> are >>>>>>>>> released, we will be able to release OpenJPA 3.0.1? >>>>>>>>> We start needing its features and fixes at Syncope... >>>>>>>>> >>>>>>>>> Regards. >>>>>>>>> >>>>>>>>> On 2018/11/13 12:50:33, Mark Struberg wrote: >>>>>>>>> > Go for it, I already removed tons of stuff for other commons >>>>> libs >>>>>>>>> which we now do not need anymore. >>>>>>>>> > >>>>>>>>> > We still need commons-dbcp (which requires commons-pool) to be >>>>>>>>> released before OpenJPA. >>>>>>>>> > >>>>>>>>> > Will try to work on that today. >>>>>>>>> > >>>>>>>>> > LieGrue, >>>>>>>>> > strub >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > > Am 13.11.2018 um 08:35 schrieb Romain Manni-Bucau : >>>>>>>>> > > >>>>>>>>> > > There is some glue code need but nothing a stream cant solve >>>>> for >>>>>>>>> most of >>>>>>>>> > > it. The main work will be the map replacement but here again, >>>>>>>>> nothing crazy >>>>>>>>> > > and worse case forking 2 classes is still worth it IMHO >>>>>>>>> > > >>>>>>>>> > > Le mar. 13 nov. 2018 07:54, Francesco Chicchiriccò a >>>>>>>>> > > écrit : >>>>>>>>> > > >>>>>>>>> > >> On 13/11/18 07:18, Romain Manni-Bucau wrote: >>>>>>>>> > >>> sounds good (but dropping a lib is too ;)) >>>>>>>>> > >> >>>>>>>>> > >> Agree: is there anything from commons-collections4 that >>>>> cannot >>>>>> be >>>>>>>>> > >> replaced by Java 8 features? Maybe some specialized >>>>> collection, >>>>>>> as >>>>>>>>> > >> CollectionUtils, IterableUtils, etc can be easily replaced. >>>>>>>>> > >> >>>>>>>>> > >> Regards. >>>>>>>>> > >> >>>>>>>>> > >> >>>>>>>>> > >>> Le mar. 13 nov. 2018 à 07:10, Maxim Solodovnik a >>>>>>>>> > >>> écrit : >>>>>>>>> > >>> >>>>>>>>> > >>>> According to this thread: >>>>>>>>> https://markmail.org/message/dnbbribu6jvzozfo >>>>>>>>> > >>>> commons-collections4 >>>>>>>>> > >>>> can >>>>>>>>> > >>>> be released in a week or so ... >>>>>>>>> > >>>> >>>>>>>>> > >>>> On Tue, 13 Nov 2018 at 13:04, Romain Manni-Bucau > >>> >>>>>>>>> > >>>> wrote: >>>>>>>>> > >>>> >>>>>>>>> > >>>>> yep, >>>>>>>>> > >>>>> >>>>>>>>> > >>>>> side note: did a quick review and I guess we can drop >>>>>>>>> > >> commons-collections >>>>>>>>> > >>>>> with not much effort since we are on java8, pool2 and >>>>> dbcp2 >>>>>>> can >>>>>>>>> > >> probably >>>>>>>>> > >>>>> too writing a thin pool for tests (like a Queue wrapper) >>>>> but >>>>>>> can >>>>>>>>> > >> require >>>>>>>>> > >>>>> more adaptation >>>>>>>>> > >>>>> >>>>>>>>> > >>>>> Le mar. 13 nov. 2018 à 06:43, Maxim Solodovnik >>>>>>>>> > >> a >>>>>>>>> > >>>>> écrit : >>>>>>>>> > >>>>> >>>>>>>>> > >>>>> Currently there are 3 SNAPSHOT dependencies >>>>>>>>> > >>>>> I'm continuously pinging commons-collections >>>>>>>>> > >>>>> >>>>>>>>> > >>>>> Other 2 are commons-pool2 and commons-dbcp2 (introduced >>> in >>>>>>>>> > >>>>> https://github.com/apache/openjpa/pull/24, currently not >>>>>>> merged) >>>>>>>>> > >>>>> >>>>>>>>> > >>>>> I guess we should get these new releases first >>>>>>>>> > >>>>> >>>>>>>>> > >>>>> >>>>>>>>> > >>>>> On Tue, 13 Nov 2018 at 12:39, Romain Manni-Bucau < >>>>>>>>> > >> rmannibu...@gmail.com> wrote: >>>>>>>>> > >>>>>>> Hi Maxim >>>>>>>>> > >>>>>>> >>>>>>>>> > >>>>>>> Tomee is waiting for a java11 release - mainly asm >>>>>> upgrade. >>>>>>>>> > >>>>>>> Once done +1 >>>>>>>>> > >>>>>>> >>>>>>>>> > >>>>>>> Le mar. 13 nov. 2018 05:03, Maxim Solodovnik >>>>>>>>> > >> a écrit : >>>>>>>>> > >>>>>>>> Hello All, >>>>>>>>> > >>>>>>>> >>>>>>>>> > >>>>>>>> 3.0.0 was release in June, lots of fixes were >>> committed >>>>>>>>> > >>>>>>>> Maybe it's time for release? >>> -- >>> Francesco Chicchiriccò >>> >>> Tirasa - Open Source Excellence >>> http://www.tirasa.net/ >>> >>> Member at The Apache Software Foundation >>> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail >>> http://home.apache.org/~ilgrosso/ >>> >>> > > -- > Francesco Chicchiriccò > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Member at The Apache Software Foundation > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail > http://home.apache.org/~ilgrosso/
