I can create PR in a minute (based on OPENJPA-2798-java11-friendly branch) Was planning to add "Automatic-Module-Name"s to manifest
On Mon, 16 Dec 2019 at 20:03, Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > > Nobody uses it but adding them breaks apps ;), yeah. > Anyway openjpa shouldnt have jpa api transitive anyway IMHO so not a big > deal while we dont break OSGi case in the feature.xml. > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > > Le lun. 16 déc. 2019 à 13:52, Mark Struberg <strub...@yahoo.de.invalid> a > écrit : > > > I'd go with fixing our module info in geronimo-jpa. > > > > But otoh nobody is using modules anyway it seems ... > > > > LieGrue, > > strub > > > > > Am 11.12.2019 um 06:39 schrieb Romain Manni-Bucau <rmannibu...@gmail.com > > >: > > > > > > Yes this one > > > > > > For openjpa the challenge will likely to not have module-info in main > > > artifacts - guess we can duplicate artifacts with a classifier jpms or > > so - > > > to avoid to break some servers and env. > > > > > > Last thing to take care: all osgi integration, i didnt check jakarta jar > > > supports it as well as our spec jar. > > > > > > So likely some validation work to do but yes it sounds like the plan. > > > > > > Hope it helps even if not a straight "yes". > > > > > > Le mer. 11 déc. 2019 à 03:57, Maxim Solodovnik <solomax...@gmail.com> a > > > écrit : > > > > > >> Do you mean this one: > > >> > > >> <dependency> > > >> <groupId>org.eclipse.persistence</groupId> > > >> <artifactId>jakarta.persistence</artifactId> > > >> <version>2.2.2</version> > > >> </dependency> > > >> > > >> Looks good to me! > > >> Shall I create PR? (the task seems to be doable for me :))) > > >> > > >> On Wed, 11 Dec 2019 at 01:03, Romain Manni-Bucau <rmannibu...@gmail.com > > > > > >> wrote: > > >> > > >>> Hi > > >>> > > >>> I proposed some time ago to rename them all but since jakarta is at > > >> eclipse > > >>> now, i guess well more move to their bundles. > > >>> > > >>> Wdyt? > > >>> > > >>> Le mar. 10 déc. 2019 à 18:18, Maxim Solodovnik <solomax...@gmail.com> > > a > > >>> écrit : > > >>> > > >>>> Hello All, > > >>>> > > >>>> not sure which list should I ask, so will start here > > >>>> > > >>>> I have started to add module-info to our project > > >>>> The issue I found is: > > >>>> openjpa depends on "Apache Geronimo JPA Spec 2.2" > > >>>> geronimo jpa doesn't have automatic module name and automatically > > being > > >>>> resolved as > > >>>> geronimo.jpa.2.2.spec > > >>>> Which is invalid java identifier :((( > > >>>> Maybe it would be possible to release same artifact with some correct > > >>>> module name for ex. `geronimo.jpa_2_2.spec` and with incremented micro > > >>>> version? > > >>>> > > >>>> Or maybe there are other options I\, not aware of? > > >>>> > > >>>> -- > > >>>> WBR > > >>>> Maxim aka solomax > > >>>> > > >>> > > >> > > >> > > >> -- > > >> WBR > > >> Maxim aka solomax > > >> > > > > -- WBR Maxim aka solomax
