rmannibucau commented on pull request #69: URL: https://github.com/apache/openjpa/pull/69#issuecomment-660127090
@eolivelli it is ok to fix herddb dict there since it is fully related IMHO. The first part of the diff is suspicious (schematool diff seems unnecessary and getColumnNames change is unlikely too). Would also be neat to not drop delimiters if the dictionnary does not use them (normalizeColumnKey). If it helps I think we can add a flag in DBIdentifier to notify it is delimited or not and have both the delimited and not delimited values (raw name vs statement name). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
