eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456502732
##########
File path:
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java
##########
@@ -2711,7 +2711,7 @@ private String getColumnAlias(Column col, PathJoins pj) {
return alias + "_" + col;
}
alias = SelectImpl.toAlias(_sel.getTableIndex(col.getTable(), pj,
false));
- return (alias == null) ? null : alias + "." + col;
+ return (alias == null) ? null : alias + "." +
_sel._dict.getNamingUtil().toDBName(col.toString());
Review comment:
the new test exercise this line.
I must be honest, with Derby it does not fail the test, even without this
line, but without this change the integration tests with HerdDB fail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
