dazey3 commented on a change in pull request #82: URL: https://github.com/apache/openjpa/pull/82#discussion_r731998843
########## File path: openjpa-persistence/src/main/java/org/apache/openjpa/persistence/JPAProperties.java ########## @@ -29,6 +29,8 @@ import org.apache.openjpa.kernel.DataCacheStoreMode; import org.apache.openjpa.lib.util.StringUtil; +import serp.util.Strings; Review comment: > if you want to reuse something StringUtil#parse is not a bad one Ah, yes this looks good. I'll use this instead. I would rather reuse any established utilities rather than rewrite the same logic with my own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org