rmannibucau commented on a change in pull request #82:
URL: https://github.com/apache/openjpa/pull/82#discussion_r732455701
##########
File path:
openjpa-persistence/src/main/java/org/apache/openjpa/persistence/JPAProperties.java
##########
@@ -29,6 +29,8 @@
import org.apache.openjpa.kernel.DataCacheStoreMode;
import org.apache.openjpa.lib.util.StringUtil;
+import serp.util.Strings;
Review comment:
More than sufficient for me, can you just add some asserts in the test
to avoid it passes silently if we break that in the future (always the risk
with "befoe it was failling" tests).
Then I'm fine to get it in (thanks a lot btw)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
