solomax commented on a change in pull request #92:
URL: https://github.com/apache/openjpa/pull/92#discussion_r772845831



##########
File path: openjpa-all/pom.xml
##########
@@ -110,6 +110,7 @@
                                         <Specification-Title>JSR-338 Java 
Persistence</Specification-Title>
                                         <Specification-Vendor>ORACLE, 
Inc.</Specification-Vendor>
                                         
<Specification-Version>2.2</Specification-Version>
+                                        
<Automatic-Module-Name>org.apache.openjpa.all</Automatic-Module-Name>

Review comment:
       From what I can see some project do have "Automatic Module name" for 
both fat-jars and regular jars
   for example Apache Tika
   
   I would expect most of users will use fat-jar-dependency
   
   Not sure what should be my next steps :(




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to