solomax commented on a change in pull request #92:
URL: https://github.com/apache/openjpa/pull/92#discussion_r771418065
##########
File path: openjpa-all/pom.xml
##########
@@ -110,6 +110,7 @@
<Specification-Title>JSR-338 Java
Persistence</Specification-Title>
<Specification-Vendor>ORACLE,
Inc.</Specification-Vendor>
<Specification-Version>2.2</Specification-Version>
+
<Automatic-Module-Name>org.apache.openjpa.all</Automatic-Module-Name>
Review comment:
I'm not sure I understand what is wrong :(
I believe every module need it's own unique name :))
I've added automatic module name to `openjpa-all` for consistency
I try to migrate my main project to JPMS and fix all
```
[WARNING] * Required filename-based automodules detected:
[openjpa-3.2.1-SNAPSHOT.jar]. Please don't publish this project to a public
artifact repository! *
```
I can leave `openjpa-all`as-is in this PR, would it be better? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
