Hi, I think the work to pass TCK should be postponed for a future release. I'd like to see a 4.1.0 (JPA 3.1) release before next tomee 10 release (a vote was recently cancelled).
Paulo. ---- Em ter, 18 mar 2025 04:31:12 -0300 Romain Manni-Bucau <rmannibu...@gmail.com> escreveu --- Hi, I guess it is just a matter of faking an em for the init time so can be a quick win but I would lower the bar to still pass previous TCK and not provide the API, should enable to still work. Romain Manni-Bucau @rmannibucau <https://x.com/rmannibucau> | .NET Blog <https://dotnetbirdie.github.io/> | Blog <https://rmannibucau.github.io/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/en-us/product/java-ee-8-high-performance-9781788473064> Le mar. 18 mars 2025 à 00:12, Paulo Araújo <mailto:cris...@vikeo.com.br.invalid> a écrit : > Hi, > > > > Fix every tests on TCK will demand too much time and I guess the project > can't wait to release. > > I guess 4.1.0 is a good number. > > Best regards, > Paulo > > > > > > > > > ---- Em dom, 16 mar 2025 22:59:35 -0300 Maxim Solodovnik < > mailto:solomax...@gmail.com> escreveu --- > > > > Hello Paulo, > > On Sun, 16 Mar 2025 at 22:18, Paulo Araújo <mailto: > mailto:cris...@vikeo.com.br.invalid> wrote: > > > > Hi, guys! > > > > I am studying OPENJPA-2925 and probably won't finish it in current > window, but I don't think it is a blocker for release. > > > > Tried to run Jakarta JPA 3.1 TCK on openjpa master, but there is a > blocker NPE on almost every test (they do EMF.getProperties() before > initializing a concrete EM). > > As far as I can see EMF with it's properties is being initialized in > `public void setUp()` of each test > I was able to get NPE if `getProperties()` is being called before EMF > is initialized ... > > I can invest some time and move everything to JUnit5 (but this change > would be huge ... :))) > > > At least the new 3.1 features passed with a quick change to avoid the > NPE. > > > > Is the version numbering correct, considering the change of JPA > dependency (3.0 to 3.1)? > > > > we can change the version to be 4.1.0 > WDYT? :) > > > Anyway, this is my non-biding +1 > > > > > > > > Best regards, > > > > Paulo > > > > > > On 2025/03/16 05:17:07 Francesco Chicchiriccò wrote: > > > > > +1 > > > > > > > > > > Thanks Maxim! > > > > > > > > > > Il dom 16 mar 2025, 02:31 Maxim Solodovnik <mailto:mailto: > mailto:so...@gmail.com> ha > > > > > scritto: > > > > > > > > > > > Hello All, > > > > > > > > > > > > recently we have fixed multiple JPA 3.1. related issues :) > > > > > > I have created PR with dependencies update: > > > > > > https://github.com/apache/openjpa/pull/128 > > > > > > > > > > > > I propose to merge #128 and release :)) > > > > > > > > > > > > -- > > > > > > Best regards, > > > > > > Maxim > > > > > > > > > > > > > > > -- > Best regards, > Maxim
