[ 
https://issues.apache.org/jira/browse/OPENJPA-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106174#comment-18106174
 ] 

Maxim Solodovnik commented on OPENJPA-2988:
-------------------------------------------

Hello [~romain.manni-bucau],

due to nature of local time it is hard to write condition which will pass :((
the test occasionally fails all the time

I can try to set something like {{00:00}} and hope test execution will not 
happen on midnight

Would it be better?

> LOCAL TIME test query is a tautology matching all rows
> ------------------------------------------------------
>
>                 Key: OPENJPA-2988
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2988
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: 
> https://github.com/apache/openjpa/pull/144#discussion_r3683006359
> **(high)** The query in testGetCurrentLocalTime was changed to 
> `localTimeField < LOCAL TIME OR localTimeField >= LOCAL TIME`, a tautology 
> matching every row no matter what LOCAL TIME evaluates to. The test now only 
> verifies the query parses. Could we keep an assertion that actually 
> constrains the result (e.g. compare against a value persisted just before)?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to