[ 
https://issues.apache.org/jira/browse/OPENJPA-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18123711#comment-18123711
 ] 

ASF subversion and git services commented on OPENJPA-2988:
----------------------------------------------------------

Commit 1f127c7ab15ef5a04a6013eeadcba66adb4e6b1f in openjpa's branch 
refs/heads/master from Paulo Cristovão de Araújo Silva Filho
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=1f127c7ab ]

Merge pull request #202 from apache/OPENJPA-2988

[OPENJPA-2988] tautology in query is removed

> LOCAL TIME test query is a tautology matching all rows
> ------------------------------------------------------
>
>                 Key: OPENJPA-2988
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2988
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: 
> https://github.com/apache/openjpa/pull/144#discussion_r3683006359
> **(high)** The query in testGetCurrentLocalTime was changed to 
> `localTimeField < LOCAL TIME OR localTimeField >= LOCAL TIME`, a tautology 
> matching every row no matter what LOCAL TIME evaluates to. The test now only 
> verifies the query parses. Could we keep an assertion that actually 
> constrains the result (e.g. compare against a value persisted just before)?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to