[ 
https://issues.apache.org/jira/browse/OPENJPA-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18107220#comment-18107220
 ] 

ASF subversion and git services commented on OPENJPA-2957:
----------------------------------------------------------

Commit 388c3ea1d43fe1ccd7b68bbea622ae59556707bb in openjpa's branch 
refs/heads/master from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=388c3ea1d ]

[OPENJPA-2957] Resolve embeddables through the metadata repository instead of 
annotation names


> hasEmbeddableAnnotation relies on annotation simple name
> --------------------------------------------------------
>
>                 Key: OPENJPA-2957
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2957
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: 
> https://github.com/apache/openjpa/pull/144#discussion_r3683000358
> **(low)** `hasEmbeddableAnnotation` matches any annotation whose simple name 
> is "Embeddable" (from any package) and misses embeddables declared only in 
> orm.xml - would checking the repository metadata (e.g. 
> `fmd.getEmbeddedMetaData()`) be more reliable than reflection on annotation 
> names?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to