rmannibucau commented on code in PR #8: URL: https://github.com/apache/openjpa-site/pull/8#discussion_r4497147491
########## .gitignore: ########## @@ -1,5 +1,100 @@ +# ============================================================================ +# Apache OpenJPA Project .gitignore +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# ============================================================================ + +# Dependencies lock files - keep these for reproducible builds +package-lock.json + +# Node modules - always excluded +node_modules/ +npm-debug.log* +yarn-debug.log* +yarn-error.log* + +# Build output directories - excluded from repo +output/ +dist/ + +# Generated static assets - NOT committed to repo, generated during build +# These are created from npm packages during CI/CD build +theme/apache/static/css/bootstrap.min.css Review Comment: I prevented myself hard to use https://www.yupiik.io/tools-maven-plugin/mojos.html#_minisite so dont expect me to promote the dead jbake, docusaurus, 11ty, hugo, roq and friends ;) for me the frontend must stay the UI (css, vendoring for the http hosting, js) and the rendering and main site can stay java what I do like with minisite (obviously I wrote it for me first so it is totally biaised) is the handlebars templating, asciidoc based (but markdown is supported at some extent but it is trivial to migrate) and doc feature complete (nav, breadcrumb, nav etc). so for me the game is really to be able to grab the doc from a released version or snapshot in site build to integrate it (a bit like antora does from git but since we are maven centered I'd grab it from maven). then a pom.xml for the pipeline = frontend for the styling + dependency to grab versioned manuals + minisite or exec for the rendering and we are good side note: think pdf can be dropped too, only all in one and nav friendly html doc are worth it IMHO today (hope this makes sense, if not we can discuss on slack if it helps to clarify what i mean) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
