Re: [PR] Site redesign: modern responsive docs theme and tooling [openjpa-site]

[rmannibucau (via GitHub) via dev]

rmannibucau commented on code in PR #8:
URL: https://github.com/apache/openjpa-site/pull/8#discussion_r4491032232


##########
theme/apache/templates/base.html:
##########
@@ -15,276 +15,156 @@
     See the License for the specific language governing permissions and
     limitations under the License.
 -->
-<html lang="en" data-bs-theme="auto">
-    <head>
-        {% block head %}
-        <meta charset="utf-8">
-        <meta name="viewport" content="width=device-width, initial-scale=1, 
shrink-to-fit=no">
-        <title>{{ SITENAME }} - {{ page.title }}</title>
-        {% endblock %}
+<html lang="en" data-bs-theme="light">
+<head>
+    {% block head %}
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1, 
shrink-to-fit=no">
+    <title>{{ SITENAME }}{% if page and page.title and page.title != SITENAME 
%} - {{ page.title }}{% endif %}</title>
+    <meta name="description" content="{% if page and page.summary %}{{ 
page.summary|striptags }}{% else %}Apache OpenJPA is an open source Java 
persistence (JPA) project at The Apache Software Foundation.{% endif %}">
+    {% endblock %}
 
-        <!-- Start favicon styles - use apache feather -->
-        <link rel="shortcut icon" 
href="https://www.apache.org/favicons/favicon.ico";>
-        <link rel="apple-touch-icon" sizes="57x57" 
href="https://www.apache.org/favicons/apple-touch-icon-57x57.png";>
-        <link rel="apple-touch-icon" sizes="60x60" 
href="https://www.apache.org/favicons/apple-touch-icon-60x60.png";>
-        <link rel="apple-touch-icon" sizes="72x72" 
href="https://www.apache.org/favicons/apple-touch-icon-72x72.png";>
-        <link rel="apple-touch-icon" sizes="76x76" 
href="https://www.apache.org/favicons/apple-touch-icon-76x76.png";>
-        <link rel="apple-touch-icon" sizes="114x114" 
href="https://www.apache.org/favicons/apple-touch-icon-114x114.png";>
-        <link rel="apple-touch-icon" sizes="120x120" 
href="https://www.apache.org/favicons/apple-touch-icon-120x120.png";>
-        <link rel="apple-touch-icon" sizes="144x144" 
href="https://www.apache.org/favicons/apple-touch-icon-144x144.png";>
-        <link rel="apple-touch-icon" sizes="152x152" 
href="https://www.apache.org/favicons/apple-touch-icon-152x152.png";>
-        <link rel="apple-touch-icon" sizes="180x180" 
href="https://www.apache.org/favicons/apple-touch-icon-180x180.png";>
-        <link rel="icon" type="image/png" 
href="https://www.apache.org/favicons/favicon-32x32.png"; sizes="32x32">
-        <link rel="icon" type="image/png" 
href="https://www.apache.org/favicons/favicon-194x194.png"; sizes="194x194">
-        <link rel="icon" type="image/png" 
href="https://www.apache.org/favicons/favicon-96x96.png"; sizes="96x96">
-        <link rel="icon" type="image/png" 
href="https://www.apache.org/favicons/android-chrome-192x192.png"; 
sizes="192x192">
-        <link rel="icon" type="image/png" 
href="https://www.apache.org/favicons/favicon-16x16.png"; sizes="16x16">
-        <meta name="msapplication-TileColor" content="#603cba">
-        <meta name="msapplication-TileImage" 
content="https://www.apache.org/favicons/mstile-144x144.png";>
-        <meta name="msapplication-config" 
content="https://www.apache.org/favicons/browserconfig.xml";>
-        <meta name="theme-color" content="#282661">
-        <!-- End favicon styles - use apache feather -->
+    <!-- Favicons -->
+    <link rel="shortcut icon" href="/favicon.ico">

Review Comment:
   @solomax think you have perms on my fork to do edits, just take care 
relative paths will break subfolders so maybe a config to add to 
pelican/frontend rendering



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org