Hi Jachym,
Another great addition to OL's vector editing capabilities!
Whilst doing some random subjective testing I noticed the following
(using FF3):
* I *can* use freehand for the 'hole' bit! Great!
* I can draw multiple holes. Great!
* After drawing the hole and double clicking, the circle does not
disappear. That's probably a minor issue
* When I draw 2 (or more) overlapping polygons, and draw the hole
in the overlapping area, the donut is created in the first drawn
polygon. Is that intended?
When I look at your patch you seem to start working with the first
feature that intersects with your mouse 'coordinates'. Wouldn't it be
more intuitive to have a selected feature and draw the hole in that one?
Then you can more easily add the donut-cababilities to the list of
modifications (like rotation, resizing, dragging and editing).
Cheers, Roald
On Thu, 2009-01-08 at 21:29 +1030, Jachym Cepicky wrote:
> Hi,
>
> I submitted new ticket with patch (needs more work) with initial
> implementation of the possibility to digitize 'hole' into existing
> polygon (donut-like polygon) [1], something like
>
>
> +-----+
> | +-+ |
> | | | |
> | +-+ |
> +-----+
>
> How to test:
>
> * Digitize polygon
> * Press CTRL key and digitize new polygon inside existing one
>
> Where to test:
>
> *
> http://dev.openlayers.org/sandbox/jachym/donut_polygons/examples/editingtoolbar.html
> *
> http://dev.openlayers.org/sandbox/jachym/donut_polygons/examples/modify-feature.html
>
> and others
>
> I would welcome any comment about the approach, I choosed. The patch
> works for me, but I can imagine, someone would like to see more
> general aproach.
>
> Thanks
>
> Jachym
>
> [1] http://trac.openlayers.org/ticket/1894
>
--
Roald de Wit
Software Engineer
roald.de...@lisasoft.com
Commercial Support for Open Source GIS Software
http://lisasoft.com/LISAsoft/SupportedProducts/
The contents of this email are confidential and may be subject to legal or
professional privilege and copyright. No representation is made that this email
is free of viruses or other defects. If you have received this communication in
error, you may not copy or distribute any part of it or otherwise disclose its
contents to anyone. Please advise the sender of your incorrect receipt of this
correspondence.
_______________________________________________
Dev mailing list
Dev@openlayers.org
http://openlayers.org/mailman/listinfo/dev
