CkNoSFeRaTU commented on a change in pull request #85:
URL: https://github.com/apache/openmeetings/pull/85#discussion_r424898978
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js
##########
@@ -211,7 +211,11 @@ var VideoUtil = (function() {
}
function _isEdge(_b) {
const b = _b || kurentoUtils.WebRtcPeer.browser;
- return b.name === 'Edge';
+ return b.name === 'Edge' && "MSGestureEvent" in window;
+ }
+ function _isEdgeChromium(_b) {
+ const b = _b || kurentoUtils.WebRtcPeer.browser;
+ return b.name === 'Edge' && !("MSGestureEvent" in window);
Review comment:
According to wiki on Windows last EdgeHTML-based edge was v44.19041 and
first chromium-based v79.0.309. But for example on android first chromium-based
Edge is v42.0.2.3928 and latest is v45.03.4.4955.
As you can see there is overlap between v42 and v44 across platforms only
with Windows and android in mind, but there are also builds for macox and ios.
So browser differentiation based only on version number is insufficient.
Are we want to support old EdgeHTML-based edge at all? Currently it is
broken due to CSP bugs with strict-dynamic and inline-unsafe, at least on
v42.17134.1098.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
