CkNoSFeRaTU commented on a change in pull request #85:
URL: https://github.com/apache/openmeetings/pull/85#discussion_r425649025
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js
##########
@@ -211,7 +211,11 @@ var VideoUtil = (function() {
}
function _isEdge(_b) {
const b = _b || kurentoUtils.WebRtcPeer.browser;
- return b.name === 'Edge';
+ return b.name === 'Edge' && "MSGestureEvent" in window;
+ }
+ function _isEdgeChromium(_b) {
+ const b = _b || kurentoUtils.WebRtcPeer.browser;
+ return b.name === 'Edge' && !("MSGestureEvent" in window);
Review comment:
I checked old EdgeHTML-based edge (v42.17134.1098.0 to be precise, it is
the latest one without insiders preview) by adding ability to disable CSP
(https://github.com/CkNoSFeRaTU/openmeetings/commit/7051c888c205334d174fe2480d011f6437fc7d3f).
It does indeed has completely broken transmission and receiving due to
kurento-utils.js trying to call **RTCPeerConnection.addTransceiver**, but
adapter.js doesn't have shim for that. Also from what I can tell this old edge
is also requiring to additionally call
**RTCPeerConnection.addIceCandidate(null)** after receiving all candidates.
Also during testing I found out that this edge by just staying in the room
will pretty fast hammer KMS:
**org.kurento.client.internal.server.KurentoServerException: Reached KMS
files limit: 819 (Code:40009, Type:null, Data:
{"type":"NOT_ENOUGH_RESOURCES"})**
And indead there are tons of hanging open UDP ports by KMS. This is probably
due to [OPENMEETINGS-2355].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
