solomax commented on a change in pull request #94:
URL: https://github.com/apache/openmeetings/pull/94#discussion_r427708419
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
##########
@@ -411,6 +411,10 @@ var DrawWbArea = function() {
width: 350
, appendTo: '.room-block .wb-block'
});
+ // Fix to move the close icon on top of the
.ui-dialog-titlebar cause otherwise
Review comment:
this code block is being repeated more than 3 times already
I believe it worth to create utility method for this ....
##########
File path: openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
##########
@@ -595,8 +595,8 @@ button.ui-button::-moz-focus-inner {
}
.ui-dialog .ui-dialog-titlebar-close {
position: absolute;
- right: .3em;
- top: 50%;
+ right: 10px;
+ top: 20px;
Review comment:
white-spaces ... :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
