sebawagner commented on a change in pull request #94:
URL: https://github.com/apache/openmeetings/pull/94#discussion_r428301937



##########
File path: 
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
##########
@@ -411,6 +411,10 @@ var DrawWbArea = function() {
                                        width: 350
                                        , appendTo: '.room-block .wb-block'
                                });
+                               // Fix to move the close icon on top of the 
.ui-dialog-titlebar cause otherwise 

Review comment:
       And its actually just 2 places. SInce we are creating dialog in 3 
different ways:
   1) DIV.dialog (jquery-ui dialog)
   2) div.draggable (making a DIV draggable)
   3) DIV.modal (Bootstap way)
   
   And each of those has its own way of fixing the issue.

##########
File path: 
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
##########
@@ -411,6 +411,10 @@ var DrawWbArea = function() {
                                        width: 350
                                        , appendTo: '.room-block .wb-block'
                                });
+                               // Fix to move the close icon on top of the 
.ui-dialog-titlebar cause otherwise 

Review comment:
       And its actually just 2 places. Since we are creating dialog in 3 
different ways:
   1) DIV.dialog (jquery-ui dialog)
   2) div.draggable (making a DIV draggable)
   3) DIV.modal (Bootstap way)
   
   And each of those has its own way of fixing the issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to