They are very useful but I understand they need to be configurable.

By default the servlet to publish the metrics would be commented out in the
web.xml:
<!-- <servlet>
<servlet-name>metrics</servlet-name>
<servlet-class>io.prometheus.client.exporter.MetricsServlet</servlet-class>
</servlet>
<servlet-mapping>
<servlet-name>metrics</servlet-name>
<url-pattern>/services/metrics/</url-pattern>
</servlet-mapping> -->

That way there would be zero impact for anybody.

Users can choose to enable via web.xml.

I would create a new PR, with minimal changes, that enables some basic
metrics (toggled off by default) [my past investigation branch has too many
changes]

And then we can discuss on a case-by-case basis to add more metrics to the
master branch.

Sounds good?

Thanks
Seb

Sebastian Wagner
Director Arrakeen Solutions, OM-Hosting.com
http://arrakeen-solutions.co.nz/
https://om-hosting.com - Cloud & Server Hosting for HTML5
Video-Conferencing OpenMeetings
<https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url>
<https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url>

Reply via email to