On Sun, 14 Feb 2021 at 06:43, [email protected] <[email protected]> wrote:
> To turn off metrics in general, we can additionally by default > > *Comment out ServletFilter for measuring HTTP request* > By commenting out by default: > > <filter> > > <filter-name>prometheusFilter</filter-name> > > ..... > > </filter> > => So by default they are turned off. > > *Make Generic Tomcat Export conditional and turned off by default* > In my test branch it loads some generic tomcat metrics (active threads). > We make those conditional based on the above servlet filter. > => So by default they are turned off. > > *Comment out aop:aspectj-autoproxy by default* > Nothing apart from the performance metrics is using aop style annotations. > By default we can just comment out in applicationContext: > > <aop:aspectj-autoproxy/> > => So by default no metrics in the application are collected. > > + commenting out Metrics servlet (as described in previous email) > > based on that: > => Everything would be turned off. No metrics collected and no metrics > exposed. > > That should be fine I assume? > Yes, this sounds safe :))) Do I need to review the changes? > > Thanks, > Seb > > Sebastian Wagner > Director Arrakeen Solutions, OM-Hosting.com > http://arrakeen-solutions.co.nz/ > https://om-hosting.com - Cloud & Server Hosting for HTML5 > Video-Conferencing OpenMeetings > < > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > < > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > On Fri, 12 Feb 2021 at 23:09, Maxim Solodovnik <[email protected]> > wrote: > > > On Fri, 12 Feb 2021 at 14:12, [email protected] < > [email protected] > > > > > wrote: > > > > > They are very useful but I understand they need to be configurable. > > > > > > By default the servlet to publish the metrics would be commented out in > > the > > > web.xml: > > > <!-- <servlet> > > > <servlet-name>metrics</servlet-name> > > > > > > <servlet-class>io.prometheus.client.exporter.MetricsServlet</servlet-class> > > > </servlet> > > > <servlet-mapping> > > > <servlet-name>metrics</servlet-name> > > > <url-pattern>/services/metrics/</url-pattern> > > > </servlet-mapping> --> > > > > > > That way there would be zero impact for anybody. > > > > > > Users can choose to enable via web.xml. > > > > > > I would create a new PR, with minimal changes, that enables some basic > > > metrics (toggled off by default) [my past investigation branch has too > > many > > > changes] > > > > > > And then we can discuss on a case-by-case basis to add more metrics to > > the > > > master branch. > > > > > > Sounds good? > > > > > > > IMO servlet is just a tiny piece of the problem > > All those annotations and timers will work and impact performance > > Can we turn everything off on annotation level? > > > > > > > > > > Thanks > > > Seb > > > > > > Sebastian Wagner > > > Director Arrakeen Solutions, OM-Hosting.com > > > http://arrakeen-solutions.co.nz/ > > > https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > Video-Conferencing OpenMeetings > > > < > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > > > > > < > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > > > > > > > > > -- > > Best regards, > > Maxim > > > -- Best regards, Maxim
